Compare a given version number in the form major.minor.build.patch and see if one is less than the other Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Displaying the number of elements larger than the average of an arrayFirst prime number larger than given integerFind smallest prime number greater than given nPrinting twin primes less than a given natural number nFind how many numbers in an array are less than each number in the arraySimple pool of threads which calculate the sum of a given number from the main processCalculate the number of palindrome numbers in the given rangesA program to find out the number of odd and even Fibonacci numbers between given rangeFind the smallest number in the first array that is not in the second oneFind the sum of the digits of a given number

When a candle burns, why does the top of wick glow if bottom of flame is hottest?

Can a non-EU citizen traveling with me come with me through the EU passport line?

What causes the vertical darker bands in my photo?

How do I name drop voicings

Should I discuss the type of campaign with my players?

How to deal with a team lead who never gives me credit?

Storing hydrofluoric acid before the invention of plastics

Why am I getting the error "non-boolean type specified in a context where a condition is expected" for this request?

How to align text above triangle figure

How does debian/ubuntu knows a package has a updated version

Compare a given version number in the form major.minor.build.patch and see if one is less than the other

How does the particle を relate to the verb 行く in the structure「A を + B に行く」?

Identifying polygons that intersect with another layer using QGIS?

Using audio cues to encourage good posture

Dating a Former Employee

Book where humans were engineered with genes from animal species to survive hostile planets

What would be the ideal power source for a cybernetic eye?

Why is "Consequences inflicted." not a sentence?

If a contract sometimes uses the wrong name, is it still valid?

At the end of Thor: Ragnarok why don't the Asgardians turn and head for the Bifrost as per their original plan?

In predicate logic, does existential quantification (∃) include universal quantification (∀), i.e. can 'some' imply 'all'?

porting install scripts : can rpm replace apt?

How to override model in magento2?

How much time will it take to get my passport back if I am applying for multiple Schengen visa countries?



Compare a given version number in the form major.minor.build.patch and see if one is less than the other



Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Displaying the number of elements larger than the average of an arrayFirst prime number larger than given integerFind smallest prime number greater than given nPrinting twin primes less than a given natural number nFind how many numbers in an array are less than each number in the arraySimple pool of threads which calculate the sum of a given number from the main processCalculate the number of palindrome numbers in the given rangesA program to find out the number of odd and even Fibonacci numbers between given rangeFind the smallest number in the first array that is not in the second oneFind the sum of the digits of a given number



.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








4












$begingroup$


#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <stdbool.h>

typedef int STATUS;
#define ERROR -1
#define OKAY 0

struct version

unsigned char major;
unsigned char minor;
unsigned char build;
unsigned char patch;
;
STATUS is_less_than(struct version * original, struct version *compared, bool *result)



Is there a cleaner way to do this?










share|improve this question









$endgroup$


















    4












    $begingroup$


    #include <stdio.h>
    #include <stdlib.h>
    #include <string.h>
    #include <stdbool.h>

    typedef int STATUS;
    #define ERROR -1
    #define OKAY 0

    struct version

    unsigned char major;
    unsigned char minor;
    unsigned char build;
    unsigned char patch;
    ;
    STATUS is_less_than(struct version * original, struct version *compared, bool *result)



    Is there a cleaner way to do this?










    share|improve this question









    $endgroup$














      4












      4








      4





      $begingroup$


      #include <stdio.h>
      #include <stdlib.h>
      #include <string.h>
      #include <stdbool.h>

      typedef int STATUS;
      #define ERROR -1
      #define OKAY 0

      struct version

      unsigned char major;
      unsigned char minor;
      unsigned char build;
      unsigned char patch;
      ;
      STATUS is_less_than(struct version * original, struct version *compared, bool *result)



      Is there a cleaner way to do this?










      share|improve this question









      $endgroup$




      #include <stdio.h>
      #include <stdlib.h>
      #include <string.h>
      #include <stdbool.h>

      typedef int STATUS;
      #define ERROR -1
      #define OKAY 0

      struct version

      unsigned char major;
      unsigned char minor;
      unsigned char build;
      unsigned char patch;
      ;
      STATUS is_less_than(struct version * original, struct version *compared, bool *result)



      Is there a cleaner way to do this?







      c






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 5 hours ago









      the_endianthe_endian

      406312




      406312




















          3 Answers
          3






          active

          oldest

          votes


















          5












          $begingroup$

          Yes, there is a cleaner way:



          if (a.major != b.major) 
          *result = a.major < b.major;
          else if (a.minor != b.minor)
          *result = a.minor < b.minor;
          else if (a.patch != b.patch)
          *result = a.patch < b.patch;
          else
          *result = a.build < b.build;

          return OKAY;


          I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



          Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






          share|improve this answer











          $endgroup$












          • $begingroup$
            Nice catch on the patch, build ordering.
            $endgroup$
            – Costantino Grana
            2 hours ago


















          1












          $begingroup$

          I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



          The danger is further complicated by the fact that neither of the in-parameters is declared const.



          Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



          With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



          bool is_less_than(struct version a, struct version b) 
          return a.major != b.major ? a.major < b.major :
          a.minor != b.minor ? a.minor < b.minor :
          a.patch != b.patch ? a.patch < b.patch :
          a.build < b.build;



          I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






          share|improve this answer









          $endgroup$




















            0












            $begingroup$

            Return status



            You create this:



            typedef int STATUS;
            #define ERROR -1
            #define OKAY 0


            which is basically a boolean status. Personally, I'd return a straight bool.



            Bug/Not what you mean



            Doing a



            result = NULL;


            is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



            Shorter version



            I'm not sure this is cleaner, but here I go:



            bool is_less_than(struct version * original, struct version *compared, bool *result)
            compared == NULL


            Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



            int main(void) 

            struct version ref = 1, 2, 21, 8 ;
            struct version lower1 = 0, 2, 21, 8 ;
            struct version lower2 = 1, 1, 21, 8 ;
            struct version lower3 = 1, 2, 20, 8 ;
            struct version lower4 = 1, 2, 21, 7 ;
            struct version equal = 1, 2, 21, 8 ;
            struct version higher1 = 2, 2, 21, 8 ;
            struct version higher2 = 1, 3, 21, 8 ;
            struct version higher3 = 1, 2, 22, 8 ;
            struct version higher4 = 1, 2, 21, 9 ;

            #define TEST(a,b,expect1,expect2)
            do
            bool result1, result2;
            is_less_than((a), (b), &result1);
            is_less_than((b), (a), &result2);
            puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
            while(0)
            #define TESTL(a,b) TEST(a,b,true,false)
            #define TESTE(a,b) TEST(a,b,false,false)
            #define TESTH(a,b) TEST(a,b,false,true)

            TESTL(&lower1, &ref);
            TESTL(&lower2, &ref);
            TESTL(&lower3, &ref);
            TESTL(&lower4, &ref);
            TESTE(&equal, &ref);
            TESTH(&higher1, &ref);
            TESTH(&higher2, &ref);
            TESTH(&higher3, &ref);
            TESTH(&higher4, &ref);

            return 0;






            share|improve this answer











            $endgroup$








            • 1




              $begingroup$
              As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
              $endgroup$
              – Roland Illig
              2 hours ago











            • $begingroup$
              @RolandIllig Updated. Thank you for the suggestion.
              $endgroup$
              – Costantino Grana
              1 hour ago











            Your Answer






            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "196"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );













            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217587%2fcompare-a-given-version-number-in-the-form-major-minor-build-patch-and-see-if-on%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            3 Answers
            3






            active

            oldest

            votes








            3 Answers
            3






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            5












            $begingroup$

            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






            share|improve this answer











            $endgroup$












            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              2 hours ago















            5












            $begingroup$

            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






            share|improve this answer











            $endgroup$












            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              2 hours ago













            5












            5








            5





            $begingroup$

            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






            share|improve this answer











            $endgroup$



            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.







            share|improve this answer














            share|improve this answer



            share|improve this answer








            edited 2 hours ago

























            answered 2 hours ago









            Roland IlligRoland Illig

            11.6k11946




            11.6k11946











            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              2 hours ago
















            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              2 hours ago















            $begingroup$
            Nice catch on the patch, build ordering.
            $endgroup$
            – Costantino Grana
            2 hours ago




            $begingroup$
            Nice catch on the patch, build ordering.
            $endgroup$
            – Costantino Grana
            2 hours ago













            1












            $begingroup$

            I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



            The danger is further complicated by the fact that neither of the in-parameters is declared const.



            Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



            With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



            bool is_less_than(struct version a, struct version b) 
            return a.major != b.major ? a.major < b.major :
            a.minor != b.minor ? a.minor < b.minor :
            a.patch != b.patch ? a.patch < b.patch :
            a.build < b.build;



            I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






            share|improve this answer









            $endgroup$

















              1












              $begingroup$

              I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



              The danger is further complicated by the fact that neither of the in-parameters is declared const.



              Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



              With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



              bool is_less_than(struct version a, struct version b) 
              return a.major != b.major ? a.major < b.major :
              a.minor != b.minor ? a.minor < b.minor :
              a.patch != b.patch ? a.patch < b.patch :
              a.build < b.build;



              I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






              share|improve this answer









              $endgroup$















                1












                1








                1





                $begingroup$

                I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



                The danger is further complicated by the fact that neither of the in-parameters is declared const.



                Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



                With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



                bool is_less_than(struct version a, struct version b) 
                return a.major != b.major ? a.major < b.major :
                a.minor != b.minor ? a.minor < b.minor :
                a.patch != b.patch ? a.patch < b.patch :
                a.build < b.build;



                I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






                share|improve this answer









                $endgroup$



                I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



                The danger is further complicated by the fact that neither of the in-parameters is declared const.



                Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



                With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



                bool is_less_than(struct version a, struct version b) 
                return a.major != b.major ? a.major < b.major :
                a.minor != b.minor ? a.minor < b.minor :
                a.patch != b.patch ? a.patch < b.patch :
                a.build < b.build;



                I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered 1 hour ago









                200_success200_success

                131k17157422




                131k17157422





















                    0












                    $begingroup$

                    Return status



                    You create this:



                    typedef int STATUS;
                    #define ERROR -1
                    #define OKAY 0


                    which is basically a boolean status. Personally, I'd return a straight bool.



                    Bug/Not what you mean



                    Doing a



                    result = NULL;


                    is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



                    Shorter version



                    I'm not sure this is cleaner, but here I go:



                    bool is_less_than(struct version * original, struct version *compared, bool *result)
                    compared == NULL


                    Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



                    int main(void) 

                    struct version ref = 1, 2, 21, 8 ;
                    struct version lower1 = 0, 2, 21, 8 ;
                    struct version lower2 = 1, 1, 21, 8 ;
                    struct version lower3 = 1, 2, 20, 8 ;
                    struct version lower4 = 1, 2, 21, 7 ;
                    struct version equal = 1, 2, 21, 8 ;
                    struct version higher1 = 2, 2, 21, 8 ;
                    struct version higher2 = 1, 3, 21, 8 ;
                    struct version higher3 = 1, 2, 22, 8 ;
                    struct version higher4 = 1, 2, 21, 9 ;

                    #define TEST(a,b,expect1,expect2)
                    do
                    bool result1, result2;
                    is_less_than((a), (b), &result1);
                    is_less_than((b), (a), &result2);
                    puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
                    while(0)
                    #define TESTL(a,b) TEST(a,b,true,false)
                    #define TESTE(a,b) TEST(a,b,false,false)
                    #define TESTH(a,b) TEST(a,b,false,true)

                    TESTL(&lower1, &ref);
                    TESTL(&lower2, &ref);
                    TESTL(&lower3, &ref);
                    TESTL(&lower4, &ref);
                    TESTE(&equal, &ref);
                    TESTH(&higher1, &ref);
                    TESTH(&higher2, &ref);
                    TESTH(&higher3, &ref);
                    TESTH(&higher4, &ref);

                    return 0;






                    share|improve this answer











                    $endgroup$








                    • 1




                      $begingroup$
                      As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                      $endgroup$
                      – Roland Illig
                      2 hours ago











                    • $begingroup$
                      @RolandIllig Updated. Thank you for the suggestion.
                      $endgroup$
                      – Costantino Grana
                      1 hour ago















                    0












                    $begingroup$

                    Return status



                    You create this:



                    typedef int STATUS;
                    #define ERROR -1
                    #define OKAY 0


                    which is basically a boolean status. Personally, I'd return a straight bool.



                    Bug/Not what you mean



                    Doing a



                    result = NULL;


                    is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



                    Shorter version



                    I'm not sure this is cleaner, but here I go:



                    bool is_less_than(struct version * original, struct version *compared, bool *result)
                    compared == NULL


                    Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



                    int main(void) 

                    struct version ref = 1, 2, 21, 8 ;
                    struct version lower1 = 0, 2, 21, 8 ;
                    struct version lower2 = 1, 1, 21, 8 ;
                    struct version lower3 = 1, 2, 20, 8 ;
                    struct version lower4 = 1, 2, 21, 7 ;
                    struct version equal = 1, 2, 21, 8 ;
                    struct version higher1 = 2, 2, 21, 8 ;
                    struct version higher2 = 1, 3, 21, 8 ;
                    struct version higher3 = 1, 2, 22, 8 ;
                    struct version higher4 = 1, 2, 21, 9 ;

                    #define TEST(a,b,expect1,expect2)
                    do
                    bool result1, result2;
                    is_less_than((a), (b), &result1);
                    is_less_than((b), (a), &result2);
                    puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
                    while(0)
                    #define TESTL(a,b) TEST(a,b,true,false)
                    #define TESTE(a,b) TEST(a,b,false,false)
                    #define TESTH(a,b) TEST(a,b,false,true)

                    TESTL(&lower1, &ref);
                    TESTL(&lower2, &ref);
                    TESTL(&lower3, &ref);
                    TESTL(&lower4, &ref);
                    TESTE(&equal, &ref);
                    TESTH(&higher1, &ref);
                    TESTH(&higher2, &ref);
                    TESTH(&higher3, &ref);
                    TESTH(&higher4, &ref);

                    return 0;






                    share|improve this answer











                    $endgroup$








                    • 1




                      $begingroup$
                      As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                      $endgroup$
                      – Roland Illig
                      2 hours ago











                    • $begingroup$
                      @RolandIllig Updated. Thank you for the suggestion.
                      $endgroup$
                      – Costantino Grana
                      1 hour ago













                    0












                    0








                    0





                    $begingroup$

                    Return status



                    You create this:



                    typedef int STATUS;
                    #define ERROR -1
                    #define OKAY 0


                    which is basically a boolean status. Personally, I'd return a straight bool.



                    Bug/Not what you mean



                    Doing a



                    result = NULL;


                    is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



                    Shorter version



                    I'm not sure this is cleaner, but here I go:



                    bool is_less_than(struct version * original, struct version *compared, bool *result)
                    compared == NULL


                    Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



                    int main(void) 

                    struct version ref = 1, 2, 21, 8 ;
                    struct version lower1 = 0, 2, 21, 8 ;
                    struct version lower2 = 1, 1, 21, 8 ;
                    struct version lower3 = 1, 2, 20, 8 ;
                    struct version lower4 = 1, 2, 21, 7 ;
                    struct version equal = 1, 2, 21, 8 ;
                    struct version higher1 = 2, 2, 21, 8 ;
                    struct version higher2 = 1, 3, 21, 8 ;
                    struct version higher3 = 1, 2, 22, 8 ;
                    struct version higher4 = 1, 2, 21, 9 ;

                    #define TEST(a,b,expect1,expect2)
                    do
                    bool result1, result2;
                    is_less_than((a), (b), &result1);
                    is_less_than((b), (a), &result2);
                    puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
                    while(0)
                    #define TESTL(a,b) TEST(a,b,true,false)
                    #define TESTE(a,b) TEST(a,b,false,false)
                    #define TESTH(a,b) TEST(a,b,false,true)

                    TESTL(&lower1, &ref);
                    TESTL(&lower2, &ref);
                    TESTL(&lower3, &ref);
                    TESTL(&lower4, &ref);
                    TESTE(&equal, &ref);
                    TESTH(&higher1, &ref);
                    TESTH(&higher2, &ref);
                    TESTH(&higher3, &ref);
                    TESTH(&higher4, &ref);

                    return 0;






                    share|improve this answer











                    $endgroup$



                    Return status



                    You create this:



                    typedef int STATUS;
                    #define ERROR -1
                    #define OKAY 0


                    which is basically a boolean status. Personally, I'd return a straight bool.



                    Bug/Not what you mean



                    Doing a



                    result = NULL;


                    is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



                    Shorter version



                    I'm not sure this is cleaner, but here I go:



                    bool is_less_than(struct version * original, struct version *compared, bool *result)
                    compared == NULL


                    Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



                    int main(void) 

                    struct version ref = 1, 2, 21, 8 ;
                    struct version lower1 = 0, 2, 21, 8 ;
                    struct version lower2 = 1, 1, 21, 8 ;
                    struct version lower3 = 1, 2, 20, 8 ;
                    struct version lower4 = 1, 2, 21, 7 ;
                    struct version equal = 1, 2, 21, 8 ;
                    struct version higher1 = 2, 2, 21, 8 ;
                    struct version higher2 = 1, 3, 21, 8 ;
                    struct version higher3 = 1, 2, 22, 8 ;
                    struct version higher4 = 1, 2, 21, 9 ;

                    #define TEST(a,b,expect1,expect2)
                    do
                    bool result1, result2;
                    is_less_than((a), (b), &result1);
                    is_less_than((b), (a), &result2);
                    puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
                    while(0)
                    #define TESTL(a,b) TEST(a,b,true,false)
                    #define TESTE(a,b) TEST(a,b,false,false)
                    #define TESTH(a,b) TEST(a,b,false,true)

                    TESTL(&lower1, &ref);
                    TESTL(&lower2, &ref);
                    TESTL(&lower3, &ref);
                    TESTL(&lower4, &ref);
                    TESTE(&equal, &ref);
                    TESTH(&higher1, &ref);
                    TESTH(&higher2, &ref);
                    TESTH(&higher3, &ref);
                    TESTH(&higher4, &ref);

                    return 0;







                    share|improve this answer














                    share|improve this answer



                    share|improve this answer








                    edited 1 hour ago

























                    answered 2 hours ago









                    Costantino GranaCostantino Grana

                    18728




                    18728







                    • 1




                      $begingroup$
                      As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                      $endgroup$
                      – Roland Illig
                      2 hours ago











                    • $begingroup$
                      @RolandIllig Updated. Thank you for the suggestion.
                      $endgroup$
                      – Costantino Grana
                      1 hour ago












                    • 1




                      $begingroup$
                      As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                      $endgroup$
                      – Roland Illig
                      2 hours ago











                    • $begingroup$
                      @RolandIllig Updated. Thank you for the suggestion.
                      $endgroup$
                      – Costantino Grana
                      1 hour ago







                    1




                    1




                    $begingroup$
                    As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                    $endgroup$
                    – Roland Illig
                    2 hours ago





                    $begingroup$
                    As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                    $endgroup$
                    – Roland Illig
                    2 hours ago













                    $begingroup$
                    @RolandIllig Updated. Thank you for the suggestion.
                    $endgroup$
                    – Costantino Grana
                    1 hour ago




                    $begingroup$
                    @RolandIllig Updated. Thank you for the suggestion.
                    $endgroup$
                    – Costantino Grana
                    1 hour ago

















                    draft saved

                    draft discarded
















































                    Thanks for contributing an answer to Code Review Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    Use MathJax to format equations. MathJax reference.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217587%2fcompare-a-given-version-number-in-the-form-major-minor-build-patch-and-see-if-on%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Magento 2 duplicate PHPSESSID cookie when using session_start() in custom php scriptMagento 2: User cant logged in into to account page, no error showing!Magento duplicate on subdomainGrabbing storeview from cookie (after using language selector)How do I run php custom script on magento2Magento 2: Include PHP script in headerSession lock after using Cm_RedisSessionscript php to update stockMagento set cookie popupMagento 2 session id cookie - where to find it?How to import Configurable product from csv with custom attributes using php scriptMagento 2 run custom PHP script

                    Can not update quote_id field of “quote_item” table magento 2Magento 2.1 - We can't remove the item. (Shopping Cart doesnt allow us to remove items before becomes empty)Add value for custom quote item attribute using REST apiREST API endpoint v1/carts/cartId/items always returns error messageCorrect way to save entries to databaseHow to remove all associated quote objects of a customer completelyMagento 2 - Save value from custom input field to quote_itemGet quote_item data using quote id and product id filter in Magento 2How to set additional data to quote_item table from controller in Magento 2?What is the purpose of additional_data column in quote_item table in magento2Set Custom Price to Quote item magento2 from controller

                    How to solve knockout JS error in Magento 2 Planned maintenance scheduled April 23, 2019 at 23:30 UTC (7:30pm US/Eastern) Announcing the arrival of Valued Associate #679: Cesar Manara Unicorn Meta Zoo #1: Why another podcast?(Magento2) knockout.js:3012 Uncaught ReferenceError: Unable to process bindingUnable to process binding Knockout.js magento 2Cannot read property `scopeLabel` of undefined on Product Detail PageCan't get Customer Data on frontend in Magento 2Magento2 Order Summary - unable to process bindingKO templates are not loading in Magento 2.1 applicationgetting knockout js error magento 2Product grid not load -— Unable to process binding Knockout.js magento 2Product form not loaded in magento2Uncaught ReferenceError: Unable to process binding “if: function()return (isShowLegend()) ” magento 2